Repository navigation
refactor: move the SDK into the unified_connectors package - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK gets a folder like every connector:
unified_connectors/with its code inunified_connectors.py, a README andtests/.__init__.pyre-exports the helpers), so connectors keep putting the repository root on their path and now importfrom unified_connectors import .... A plain folder would not work: pytest registers a folder's name while collecting its tests, which shadowed the module.kvupdated; all 82 tests pass, run aspytestand aspython -m pytest, and scripts still run from any working directory.check-public.shskips__pycache__.